-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove the word "necessary" from optional fields #5659
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 7894271127Details
💛 - Coveralls |
1ca49a6
to
54c18f3
Compare
54c18f3
to
b7591d6
Compare
Would it be possible to clarify this bit:
If you're in a private cluster with access to internet via NAT gateway, you'll reach IAM over the public internet, so it would be good to know the implications of this in terms of cost, does it contact the endpoint just once to generate the profile or is it a repetitive process? |
I'm not sure what you mean in terms of cost. IAM entities don't incur additional cost so I don't think that should be a concern there. In terms of the actual behavior of Karpenter, it is a continuous reconciliation so if you were to delete the instance profile accidentally or remove the role, Karpenter would add it back. You need constant access to IAM if you are using the |
Possibly I'm missing something, if using an instance profile, it wouldn't go over public internet to IAM, whereas with a role it would and do so continuously to reconcile? Sounds like it would cost more |
Fixes #N/A
Description
This updates the docs to clarify that only one of
spec.role
andspec.instanceProfile
is needed since the previous wording might have been confusing with respect to this.How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.