Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix docgen #5673

Merged
merged 1 commit into from
Feb 16, 2024
Merged

docs: Fix docgen #5673

merged 1 commit into from
Feb 16, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Fix failures in docgen due to not discovering stateSubsystem

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner February 16, 2024 01:34
@jonathan-innis jonathan-innis enabled auto-merge (squash) February 16, 2024 01:34
@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 78351e2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65cebbf01ada4f0008f8e11d
😎 Deploy Preview https://deploy-preview-5673--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Feb 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7924768152

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.497%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 7924636848: -0.02%
Covered Lines: 5015
Relevant Lines: 6079
💛 - Coveralls

jigisha620
jigisha620 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 8dca0d3 into aws:main Feb 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigisha620 jigisha620 jigisha620 approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @jigisha620