Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix helm diff and crane digest command #5674

Merged
merged 2 commits into from
Feb 16, 2024
Merged

ci: Fix helm diff and crane digest command #5674

merged 2 commits into from
Feb 16, 2024

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Feb 16, 2024 •
edited
Loading

Fixes #N/A

Description

Fix helm diff command in our E2E test jobs
Fix the call to crane to make sure that it is pulling the digest from the correct repo

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner February 16, 2024 05:10
@jonathan-innis jonathan-innis enabled auto-merge (squash) February 16, 2024 05:10
@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 595cf92
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65ceef56c4b1c8000812c8d3

@coveralls
Copy link

coveralls commented Feb 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7926358291

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.497%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 7926173490: -0.02%
Covered Lines: 5015
Relevant Lines: 6079
💛 - Coveralls

@jonathan-innis jonathan-innis changed the title ci: Fix helm diff command ci: Fix helm diff and crane digest command Feb 16, 2024
engedaam
engedaam approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit c73c4d8 into aws:main Feb 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @engedaam