-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Changed OCI tag format #5680
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
Pull Request Test Coverage Report for Build 8027504602Details
💛 - Coveralls |
84d6883
to
e4f9e59
Compare
e4f9e59
to
badec6b
Compare
@jonathan-innis I've updated the docs and have standardised the pattern used to refer to Karpenter versions for consistency (see below). Karpenter version: `0.34.1`
Karpenter minimum version: `0.34.0`+
Karpenter latest patch: `0.34.x` (this shouldn't be used where the minimum version would also work) |
badec6b
to
f0d1de1
Compare
Signed-off-by: Steve Hipwell <[email protected]>
030b53f
to
384500b
Compare
384500b
to
f343580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
05105e1
to
c9a36c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
This PR changes the OCI tag pattern to be the SemVer version without the
v
prefix.How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.