Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed OCI tag format #5680

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Conversation

stevehipwell
Copy link
Contributor

Fixes #N/A

Description
This PR changes the OCI tag pattern to be the SemVer version without the v prefix.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit c9a36c2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65d94fa4b9644d0008feb87d

@stevehipwell
Copy link
Contributor Author

CC @jonathan-innis

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Show resolved Hide resolved
hack/release/stable-pr.sh Outdated Show resolved Hide resolved
hack/release/release.sh Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
hack/release/common.sh Show resolved Hide resolved
hack/release/common.sh Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 8027504602

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.595%

Totals Coverage Status
Change from base Build 8025902954: 0.0%
Covered Lines: 5054
Relevant Lines: 6119

💛 - Coveralls

@stevehipwell stevehipwell force-pushed the image-semver-tag branch 4 times, most recently from 84d6883 to e4f9e59 Compare February 23, 2024 11:32
@stevehipwell stevehipwell marked this pull request as ready for review February 23, 2024 11:33
@stevehipwell stevehipwell requested a review from a team as a code owner February 23, 2024 11:33
@stevehipwell
Copy link
Contributor Author

@jonathan-innis I've updated the docs and have standardised the pattern used to refer to Karpenter versions for consistency (see below).

Karpenter version: `0.34.1`
Karpenter minimum version: `0.34.0`+
Karpenter latest patch: `0.34.x` (this shouldn't be used where the minimum version would also work)

Signed-off-by: Steve Hipwell <[email protected]>
@jonathan-innis jonathan-innis force-pushed the image-semver-tag branch 2 times, most recently from 030b53f to 384500b Compare February 24, 2024 01:33
jonathan-innis
jonathan-innis previously approved these changes Feb 24, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

jonathan-innis
jonathan-innis previously approved these changes Feb 24, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 3c4b0bf into aws:main Feb 24, 2024
17 checks passed
@stevehipwell stevehipwell deleted the image-semver-tag branch February 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants