Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: AL2023 AMI Family docs #5714

Merged
merged 1 commit into from
Feb 28, 2024
Merged

docs: AL2023 AMI Family docs #5714

merged 1 commit into from
Feb 28, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 22, 2024

Fixes #N/A

Description
Doc updates for the AL2023 AMI family.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal added the blocked Unable to make progress due to some dependency label Feb 22, 2024
@jmdeal jmdeal requested a review from a team as a code owner February 22, 2024 23:00
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 339ba39
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65de6927ef41cb0007474620
😎 Deploy Preview https://deploy-preview-5714--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Feb 22, 2024

Pull Request Test Coverage Report for Build 8072481941

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 82.579%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 8060922119: -0.05%
Covered Lines: 5053
Relevant Lines: 6119

💛 - Coveralls

@jmdeal jmdeal force-pushed the al2023-docs branch 2 times, most recently from 4ff5072 to a505433 Compare February 23, 2024 00:29
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-a505433c144f9412134055542a8e7a82b3537607.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot --version "0-a505433c144f9412134055542a8e7a82b3537607" --namespace "kube-system" --create-namespace   --set "settings.clusterName=${CLUSTER_NAME}"   --set "settings.interruptionQueue=${CLUSTER_NAME}"   --set controller.resources.requests.cpu=1   --set controller.resources.requests.memory=1Gi   --set controller.resources.limits.cpu=1   --set controller.resources.limits.memory=1Gi   --wait

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jmdeal jmdeal force-pushed the al2023-docs branch 2 times, most recently from 1551465 to 61c44da Compare February 27, 2024 21:39
@jmdeal jmdeal removed the blocked Unable to make progress due to some dependency label Feb 28, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One comment!

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit bc96541 into aws:main Feb 28, 2024
20 checks passed
@jmdeal jmdeal deleted the al2023-docs branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants