Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: RFC Supporting ODCR in Karpenter #5716

Merged
merged 43 commits into from
Sep 6, 2024
Merged

docs: RFC Supporting ODCR in Karpenter #5716

merged 43 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. Create odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5578571 View commit details
    Browse the repository at this point in the history

  2. Continue on doc

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cc20d78 View commit details
    Browse the repository at this point in the history

  3. launching nodes in CRs

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    84ed310 View commit details
    Browse the repository at this point in the history

  4. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dec184f View commit details
    Browse the repository at this point in the history

  5. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8510392 View commit details
    Browse the repository at this point in the history

  6. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4838d33 View commit details
    Browse the repository at this point in the history

  7. fail scenario

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0bef8c5 View commit details
    Browse the repository at this point in the history

  8. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    32d48c4 View commit details
    Browse the repository at this point in the history

  9. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    950832d View commit details
    Browse the repository at this point in the history

  10. failure

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    544172a View commit details
    Browse the repository at this point in the history

  11. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a47b6d4 View commit details
    Browse the repository at this point in the history

  12. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9bd0078 View commit details
    Browse the repository at this point in the history

  13. Update odcr.md

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    520b44f View commit details
    Browse the repository at this point in the history

  14. Update designs/odcr.md 

    Co-authored-by: Jonathan Innis <[email protected]>
    @garvinp-stripe @jonathan-innis
    garvinp-stripe and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    743f5fe View commit details
    Browse the repository at this point in the history

  15. Update designs/odcr.md 

    Co-authored-by: Jonathan Innis <[email protected]>
    @garvinp-stripe @jonathan-innis
    garvinp-stripe and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f31504f View commit details
    Browse the repository at this point in the history

  16. PR comments + costing/pricing

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cba3f55 View commit details
    Browse the repository at this point in the history

  17. add more to consolidation + createfleet behavior

    @garvinp-stripe @jonathan-innis
    garvinp-stripe authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9d2c59a View commit details
    Browse the repository at this point in the history

  18. add odcr information from current poc implementation

    @tvonhacht-apple @jonathan-innis
    tvonhacht-apple authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b5c9de3 View commit details
    Browse the repository at this point in the history

  19. fix typos and clunky sentences

    @tvonhacht-apple @jonathan-innis
    tvonhacht-apple authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b3e1708 View commit details
    Browse the repository at this point in the history

  20. Adresse RFC comments

    @tvonhacht-apple @jonathan-innis
    tvonhacht-apple authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b9e2d6a View commit details
    Browse the repository at this point in the history

  21. Add support of open and targeted ODCRs

    @tvonhacht-apple @jonathan-innis
    tvonhacht-apple authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    319b871 View commit details
    Browse the repository at this point in the history

  22. Update docs to not use capacity-type capacity-reservation

    @tvonhacht-apple @jonathan-innis
    tvonhacht-apple authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    14b9531 View commit details
    Browse the repository at this point in the history

  23. Update Goals/Non-Goals

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5ca00ca View commit details
    Browse the repository at this point in the history

  24. Drop some fields from status API

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5ec34d6 View commit details
    Browse the repository at this point in the history

  25. Add NodePool selection options section

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    10ae3b4 View commit details
    Browse the repository at this point in the history

  26. Add scheduling representation sections

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    afee12f View commit details
    Browse the repository at this point in the history

  27. Add additional comments about consolidating between ODCRs

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    06be8d6 View commit details
    Browse the repository at this point in the history

  28. Reoranizing sections

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    27b605d View commit details
    Browse the repository at this point in the history

  29. Add drift section

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dd6d3c7 View commit details
    Browse the repository at this point in the history

  30. Update example offerings

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4cb37cf View commit details
    Browse the repository at this point in the history

  31. Add note about performance benchmarking

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    20cf260 View commit details
    Browse the repository at this point in the history

  32. Final review, last open questions is appendix, text for odcr first sc… 

    …heduling and what label to use
    @tvonhacht-apple @jonathan-innis
    tvonhacht-apple authored and jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5e4e21a View commit details
    Browse the repository at this point in the history

  33. Update RFC with closed api decision

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    99debfa View commit details
    Browse the repository at this point in the history

  34. Add note on mutual exclusivity of fields

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3877835 View commit details
    Browse the repository at this point in the history

  35. Edits after maintainer review

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    163e6c3 View commit details
    Browse the repository at this point in the history

  36. Add section on open ODCRs

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a0cad76 View commit details
    Browse the repository at this point in the history

  37. Add section on prioritizing ODCRs during scheduling

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    be1c6c5 View commit details
    Browse the repository at this point in the history

  38. Update ToC

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d43fc38 View commit details
    Browse the repository at this point in the history

  39. Add CreateFleet appendix examples

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7bc0614 View commit details
    Browse the repository at this point in the history

  40. Convert some outputs to table

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3a7841b View commit details
    Browse the repository at this point in the history

  41. Combine some rows in the appendix

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    73a8efb View commit details
    Browse the repository at this point in the history

  42. PR comments

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0579fdb View commit details
    Browse the repository at this point in the history

  43. Add a note on prioritizing reserved

    @jonathan-innis
    jonathan-innis committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    84174d0 View commit details
    Browse the repository at this point in the history