Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use KOCACHE for image build #5723

Merged
merged 1 commit into from
Feb 23, 2024
Merged

ci: use KOCACHE for image build #5723

merged 1 commit into from
Feb 23, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 23, 2024

Fixes #N/A

Description
Defaults KOCACHE to ~/.ko to speed up image builds.

How was this change tested?
make image

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner February 23, 2024 21:41
@jmdeal jmdeal requested a review from bwagner5 February 23, 2024 21:41
@netlify Netlify
Copy link

netlify bot commented Feb 23, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6a648cd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65d91117c0351b0008490b8e

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8025406710

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.579%
Totals Coverage Status
Change from base Build 8025066475: 0.0%
Covered Lines: 5053
Relevant Lines: 6119
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@jmdeal jmdeal merged commit 64ad272 into aws:main Feb 23, 2024
17 checks passed
@jmdeal jmdeal deleted the kocache branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmdeal @coveralls @jonathan-innis