Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove unused release-crd target #5724

Merged
merged 1 commit into from
Feb 24, 2024
Merged

ci: Remove unused release-crd target #5724

merged 1 commit into from
Feb 24, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Removes unneeded release-crd target from the Makefile, along with unused environment variables

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner February 24, 2024 01:46
@jonathan-innis jonathan-innis enabled auto-merge (squash) February 24, 2024 01:46
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2024 •
edited
Loading

❌ Deploy Preview for karpenter-docs-prod failed.

Name Link
🔨 Latest commit d8d6706
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65d9613aeef7f500081bf408

@coveralls
Copy link

coveralls commented Feb 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8027912179

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.579%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8027651135: -0.02%
Covered Lines: 5053
Relevant Lines: 6119
💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the remove-release-crd-target branch 2 times, most recently from 6b62399 to 6e814a8 Compare February 24, 2024 03:00
jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Feb 24, 2024
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d8d6706ffc7e4e7d0eafa7202a62aa2aa87a2207.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot --version "0-d8d6706ffc7e4e7d0eafa7202a62aa2aa87a2207" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jmdeal
jmdeal approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 8fa6a51 into aws:main Feb 24, 2024
16 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @jmdeal