Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations #5816

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Mar 8, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner March 8, 2024 22:12
@engedaam engedaam requested a review from ellistarn March 8, 2024 22:12
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6288691
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65ebb53b1eb9c900074c5cb5

@coveralls
Copy link

coveralls commented Mar 8, 2024

Pull Request Test Coverage Report for Build 8210967087

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 82.727%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 8209694900: 0.02%
Covered Lines: 5302
Relevant Lines: 6409

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

pkg/providers/instancetype/instancetype.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the update-instancetype-hash branch 2 times, most recently from 60fe994 to fb2ed56 Compare March 8, 2024 23:01
@engedaam engedaam changed the title chore: Include volumeSize in Instancetype hash calculations chore: Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations Mar 8, 2024
@engedaam engedaam changed the title chore: Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations chore: Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations Mar 8, 2024
@engedaam engedaam force-pushed the update-instancetype-hash branch 4 times, most recently from cbfe699 to 70d7ed5 Compare March 9, 2024 00:25
@engedaam engedaam force-pushed the update-instancetype-hash branch 2 times, most recently from eafcde3 to ed5a8d9 Compare March 9, 2024 01:02
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🎉

@engedaam engedaam merged commit 16992b6 into aws:main Mar 9, 2024
17 checks passed
@engedaam engedaam deleted the update-instancetype-hash branch March 9, 2024 01:27
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 11, 2024
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 11, 2024
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 11, 2024
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 11, 2024
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 11, 2024
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 11, 2024
engedaam added a commit to engedaam/karpenter that referenced this pull request Mar 11, 2024
engedaam added a commit that referenced this pull request Mar 11, 2024
engedaam added a commit that referenced this pull request Mar 11, 2024
engedaam added a commit that referenced this pull request Mar 11, 2024
engedaam added a commit that referenced this pull request Mar 11, 2024
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants