-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Include volumeSize
, kubeReserved
, and systemReserved
in Instancetype hash calculations
#5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 8210967087Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
engedaam
force-pushed
the
update-instancetype-hash
branch
2 times, most recently
from
March 8, 2024 23:01
60fe994
to
fb2ed56
Compare
engedaam
changed the title
chore: Include volumeSize in Instancetype hash calculations
chore: Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations
Mar 8, 2024
engedaam
changed the title
chore: Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations
chore: Include Mar 8, 2024
volumeSize
, kubeReserved
, and systemReserved
in Instancetype hash calculations
engedaam
force-pushed
the
update-instancetype-hash
branch
4 times, most recently
from
March 9, 2024 00:25
cbfe699
to
70d7ed5
Compare
engedaam
force-pushed
the
update-instancetype-hash
branch
2 times, most recently
from
March 9, 2024 01:02
eafcde3
to
ed5a8d9
Compare
engedaam
force-pushed
the
update-instancetype-hash
branch
from
March 9, 2024 01:02
ed5a8d9
to
6288691
Compare
jonathan-innis
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🎉
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (aws#5816)
3 tasks
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (aws#5816)
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (aws#5816)
3 tasks
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (aws#5816)
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (aws#5816)
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (aws#5816)
engedaam
added a commit
to engedaam/karpenter
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (aws#5816)
engedaam
added a commit
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (#5816)
engedaam
added a commit
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (#5816)
engedaam
added a commit
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (#5816)
engedaam
added a commit
that referenced
this pull request
Mar 11, 2024
…Instancetype hash calculations (#5816)
johngmyers
pushed a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
…Instancetype hash calculations (aws#5816)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
kubeReserved
, andsystemReserved
hash are also not included in the instancetype cache keysystemReserved
andkubeReserved
don't trigger drift kubernetes-sigs/karpenter#1080. Karpenter will hash them as a string.How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.