chore(cherry-pick to v0.32.x): Include volumeSize, kubeReserved, and systemReserved in Instancetype hash calculations #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engedaam
force-pushed
the
instance-type-fix-v0.32
branch
2 times, most recently
from
8a091a1
to
5a02de8
Compare
…Instancetype hash calculations (aws#5816)
engedaam
force-pushed
the
instance-type-fix-v0.32
branch
from
5a02de8
to
cf85c63
Compare
Pull Request Test Coverage Report for Build 8238225548Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
kubeReserved, andsystemReservedhash are also not included in the instancetype cache keysystemReservedandkubeReserveddon't trigger drift kubernetes-sigs/karpenter#1080. Karpenter will hash them as a string.How was this change tested?
-N/A
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.