Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix the clean-up for instanceProfile to catch InstanceProfileName #5834

Merged
merged 1 commit into from
Mar 12, 2024
Merged

chore: fix the clean-up for instanceProfile to catch InstanceProfileName #5834

merged 1 commit into from
Mar 12, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Mar 11, 2024 •
edited
Loading

Fixes #N/A

Description

  • The clean-up script was not grabbing the correct tag to get the instance profile name. Fixed the tags and switched to using data from the ListInstanceProfileTags API call
  • Also changed to using the instance profile tag for region to properly identify instance profiles to clean-up

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner March 11, 2024 23:34
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4c8ee33
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65efa128a86b5c0008016f4d

@coveralls
Copy link

coveralls commented Mar 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8241616656

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.743%
Totals Coverage Status
Change from base Build 8240707999: 0.02%
Covered Lines: 5303
Relevant Lines: 6409
💛 - Coveralls

@engedaam engedaam force-pushed the fix-instance-profile-cleanup branch from 6d60c2e to e043d05 Compare March 12, 2024 00:19
jonathan-innis
jonathan-innis previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam force-pushed the fix-instance-profile-cleanup branch from e043d05 to 4c8ee33 Compare March 12, 2024 00:26
@engedaam engedaam enabled auto-merge (rebase) March 12, 2024 00:39
jonathan-innis
jonathan-innis approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 916bfd7 into aws:main Mar 12, 2024
16 checks passed
@engedaam engedaam deleted the fix-instance-profile-cleanup branch March 13, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis