Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only upload artifacthub metadata to release repo #5875

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Mar 15, 2024

Fixes #N/A

Description
This change ensures that we only upload ArtifactHub metadata to the release ECR repo. The snapshot repo has tag immutability enabled and it really isn't needed there anyway.

How was this change tested?
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner March 15, 2024 17:46
@jmdeal jmdeal requested a review from tzneal March 15, 2024 17:46
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 0fac194
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65f4898dac1a880008a94628

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-0fac1941b0cd3d86ef14643de157c5f98ed5135a.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-0fac1941b0cd3d86ef14643de157c5f98ed5135a" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8300294468

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.443%

Totals Coverage Status
Change from base Build 8299801336: 0.0%
Covered Lines: 5339
Relevant Lines: 6476

💛 - Coveralls

@jmdeal jmdeal merged commit a4d93bd into aws:main Mar 15, 2024
24 of 29 checks passed
@jmdeal jmdeal deleted the ah-metadata-release-only branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants