Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick(v0.34): feat: Add Versioned for EC2NodeClass Hash to Prevent Drift on EC2NodeClass CRD Upgrade #5927

Merged
merged 4 commits into from
Mar 26, 2024
Merged

cherrypick(v0.34): feat: Add Versioned for EC2NodeClass Hash to Prevent Drift on EC2NodeClass CRD Upgrade #5927

merged 4 commits into from
Mar 26, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

  • /karpetner snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam
Copy link
Contributor Author

Holding until we bump the Karpenter version.

@engedaam engedaam changed the title cherrypick(v0.34.x): feat: Add Versioned for EC2NodeClass Hash to Prevent Drift on EC2NodeClass CRD Upgrade cherrypick(v0.34): feat: Add Versioned for EC2NodeClass Hash to Prevent Drift on EC2NodeClass CRD Upgrade Mar 26, 2024
@engedaam engedaam marked this pull request as ready for review March 26, 2024 16:26
@engedaam engedaam requested a review from a team as a code owner March 26, 2024 16:26
@coveralls
Copy link

coveralls commented Mar 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8439650417

Details

  • 44 of 50 (88.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 82.649%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclass/controller.go 31 37 83.78%
Totals Coverage Status
Change from base Build 8428626463: 0.03%
Covered Lines: 5092
Relevant Lines: 6161
💛 - Coveralls

jigisha620
jigisha620 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@engedaam engedaam merged commit 2a5ba41 into aws:release-v0.34.x Mar 26, 2024
12 checks passed
@engedaam engedaam deleted the patch-v0.34 branch March 26, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigisha620 jigisha620 jigisha620 approved these changes

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis jonathan-innis is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jigisha620