Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Delete launch template with context #6021

Merged
merged 1 commit into from
Apr 11, 2024
Merged

chore: Delete launch template with context #6021

merged 1 commit into from
Apr 11, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Update call from DeleteLaunchTemplate to use context.Context like other SDK functions

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 11, 2024 02:53
@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 92de54d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6617562d61c6b000084deec4

@coveralls
Copy link

coveralls commented Apr 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8641022168

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.261%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/launchtemplate/launchtemplate.go 0 1 0.0%
Totals Coverage Status
Change from base Build 8639149830: 0.02%
Covered Lines: 5333
Relevant Lines: 6483
💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the delete-launch-template-with-context branch from 8512c47 to 92de54d Compare April 11, 2024 03:17
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 11, 2024 03:17
engedaam
engedaam approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 6439883 into aws:main Apr 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@jigisha620 jigisha620 Awaiting requested review from jigisha620 jigisha620 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @engedaam