-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart): Correct fix for ServiceMonitor indentation #6029
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@stevehipwell Can you post an example ServiceMonitor that you are expecting to be produced? |
@engedaam I expect the ServiceMonitor to render correctly as it did when I refactored the Helm chart (before the two PRs mentioned in the description). |
Signed-off-by: Steve Hipwell <[email protected]>
1a00219
to
68e4b2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Pull Request Test Coverage Report for Build 8689730314Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Snapshot successfully published to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@engedaam I don't think the failing E2E test is related to the changes. |
Yeah, I agree the failing test is not related to the changes. |
Fixes #N/A
Description
This fixes the pattern in the Helm
ServiceMonitor
template where the code was broken by #5571 (I have no idea why it was merged, but I suspect it was a fix for the pre-refactored chart version) and incorrectly fixed by #5624; thenindent
value should match the indentation of the{{}}
block.How was this change tested?
I've tested this locally.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.