Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update endpointConfig comment for the helm values #6044

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Update the endpointConfig helm field to be used as additional fields for http-metrics endpoint.

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 16, 2024 01:34
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 78d2822
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/661dd8af379c1d00083584ce

@engedaam engedaam changed the title chore: Update endpoint comment chore: Update endpointConfig comment for the helm values Apr 16, 2024
@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8698701528

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.0%

Totals Coverage Status
Change from base Build 8698337440: 0.0%
Covered Lines: 5371
Relevant Lines: 6550

💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Apr 16, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

charts/karpenter/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 342f753 into aws:main Apr 16, 2024
17 checks passed
@engedaam engedaam deleted the update-endpoint branch April 18, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants