Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update apigroup from const to var #6046

Merged
merged 1 commit into from
Apr 16, 2024
Merged

chore: Update apigroup from const to var #6046

merged 1 commit into from
Apr 16, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Update apigroup from const to var

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner April 16, 2024 19:07
@netlify Netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 415a961
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/661ecda184e7b60008a2e03e

engedaam
engedaam previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) April 16, 2024 19:12
engedaam
engedaam approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8711207396

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.015%
Totals Coverage Status
Change from base Build 8709685881: 0.0%
Covered Lines: 5372
Relevant Lines: 6550
💛 - Coveralls

@jonathan-innis jonathan-innis merged commit b692129 into aws:main Apr 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @engedaam