Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move Pricing controller to a providers controllers package #6052

Merged
merged 1 commit into from
Apr 18, 2024
Merged

chore: Move Pricing controller to a providers controllers package #6052

merged 1 commit into from
Apr 18, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Moving pricing controller to a pricing providers package

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner April 18, 2024 00:41
@engedaam engedaam requested a review from jmdeal April 18, 2024 00:41
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 7852c2e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66206c7de8604800085c4e7d

@engedaam engedaam changed the title chore: Move Pricing controller to a providers controllers chore: Move Pricing controller to a providers controllers package Apr 18, 2024
jonathan-innis
jonathan-innis approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) April 18, 2024 00:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8730620290

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.0%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 8713470070: -0.02%
Covered Lines: 5371
Relevant Lines: 6550
💛 - Coveralls

@engedaam engedaam merged commit e6f7b0c into aws:main Apr 18, 2024
17 checks passed
@engedaam engedaam deleted the moving-pricing-controller branch April 18, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jonathan-innis