-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add support for Ubuntu 22.04 #6054
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @engedaam |
I'll let @jmdeal to add some additional thoughts here, but there's still some ongoing discussion in #5572. I wonder if we can push for getting SSM support in (#3657) and userData templating (#5134) if that would be a better path forward than continuing to add more support for the Ubuntu AMIFamily as they continue to bump their major version. |
Test cases have been fixed. |
…ovider-aws; branch 'main' of github.com:aws/karpenter-provider-aws into ubuntu-2004-2204
Thanks for the PR @AhmadMasry, but like @jonathan-innis mentioned we're still deciding if we want to continue supporting Ubuntu AMI families natively. The rationale he gave in the issue summarizes our thoughts best:
This is why support hasn't been added yet and #5861 was closed out. Personally, I do think SSM parameters and user data templating are probably the best long term option here since they'll enable feature parity for current Ubuntu family users without requiring native support (in addition to supporting other use cases). |
Thank you @jmdeal for your feedback. |
Hi @jonathan-innis @jmdeal |
…-2004-2204 # Conflicts: # test/suites/integration/ami_test.go # test/suites/integration/kubelet_config_test.go
Given that we're currently planning on dropping support for Ubuntu as a managed AMI family at v1 (v1 Roadmap Proposal), we don't want to signal future support at this point. Ubuntu 22.04 still be used with the Ubuntu AMI family and AMI selector terms for users migrating to k8s 1.30 once Canonical releases 1.30 EKS optimized AMIs. |
Fixes 5572
Description
amiFamily
which areUbuntu2004
,Ubuntu2204
have been introduced.Ubuntu2204
amiFamily
can only be used for Kubernetes 1.29+.amiFamily
Ubuntu
is equivalent toUbuntu2004
.How was this change tested?
I tested it on an EKS cluster with version 1.29 using
Ubuntu
,Ubuntu2004
andUbuntu2204
and all have worked and provisioned.Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.