Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for Ubuntu 22.04 #6054

Closed
wants to merge 15 commits into from

Conversation

AhmadMasry
Copy link

@AhmadMasry AhmadMasry commented Apr 18, 2024

Fixes 5572

Description

  • The Ubuntu EKS optimized AMI started to support 22.04 for Kubernetes 1.29+, to make sure that 20.04 and 22.04 can be used, two new amiFamily which are Ubuntu2004, Ubuntu2204 have been introduced.
  • Ubuntu2204 amiFamily can only be used for Kubernetes 1.29+.
  • For backward compatibility, amiFamily Ubuntu is equivalent to Ubuntu2004.
  • This change can be useful if the upcoming Ubuntu 24.04 will be supported as an Ubuntu EKS optimized AMI and the older versions will be supported until the end of LTS standard security maintenance for Ubuntu Main.

How was this change tested?
I tested it on an EKS cluster with version 1.29 using Ubuntu, Ubuntu2004 and Ubuntu2204 and all have worked and provisioned.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AhmadMasry AhmadMasry requested a review from a team as a code owner April 18, 2024 03:49
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit cbfd779
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/663b6e961762ef00085d5d2e
😎 Deploy Preview https://deploy-preview-6054--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AhmadMasry
Copy link
Author

Hi @engedaam
Can you have a look at this PR, and if you have any notes or comments please feel free to provide them so I can do the needed changed.
Thanks

@jonathan-innis
Copy link
Contributor

Can you have a look at this PR, and if you have any notes or comments please feel free to provide them so I can do the needed changed

I'll let @jmdeal to add some additional thoughts here, but there's still some ongoing discussion in #5572. I wonder if we can push for getting SSM support in (#3657) and userData templating (#5134) if that would be a better path forward than continuing to add more support for the Ubuntu AMIFamily as they continue to bump their major version.

@AhmadMasry
Copy link
Author

Test cases have been fixed.

AhmadMasry and others added 2 commits April 24, 2024 22:17
…ovider-aws; branch 'main' of github.com:aws/karpenter-provider-aws into ubuntu-2004-2204
@jmdeal
Copy link
Contributor

jmdeal commented Apr 29, 2024

Thanks for the PR @AhmadMasry, but like @jonathan-innis mentioned we're still deciding if we want to continue supporting Ubuntu AMI families natively. The rationale he gave in the issue summarizes our thoughts best:

It's still unclear whether we want to have direct support for the Ubuntu AMIFamilies going forward due to the number of times that the latest version of the Ubuntu image has broken people -- and for extended periods of time.

This is why support hasn't been added yet and #5861 was closed out. Personally, I do think SSM parameters and user data templating are probably the best long term option here since they'll enable feature parity for current Ubuntu family users without requiring native support (in addition to supporting other use cases).

@AhmadMasry
Copy link
Author

Thank you @jmdeal for your feedback.
I think supporting 22.04 can be a short-term fix, until the SSM parameters and user data templating are supported.
I sent to Canonical and it seems that supporting 24.04 EKS AMIs is not on their roadmap yet, so I do not think the support of 24.04 will be needed in the short term and until the SSM parameters and user data templating are supported, This PR can utilized to use the newer ubuntu images.

@AhmadMasry
Copy link
Author

Hi @jonathan-innis @jmdeal
So, do you want me to close the PR? or do you want to go with my suggestion to support 22.04 until SSM parameters and user data templating are supported?
Thank you for your efforts.

AhmadMasry and others added 3 commits May 5, 2024 11:26
…-2004-2204

# Conflicts:
#	test/suites/integration/ami_test.go
#	test/suites/integration/kubelet_config_test.go
@jmdeal
Copy link
Contributor

jmdeal commented May 8, 2024

Given that we're currently planning on dropping support for Ubuntu as a managed AMI family at v1 (v1 Roadmap Proposal), we don't want to signal future support at this point. Ubuntu 22.04 still be used with the Ubuntu AMI family and AMI selector terms for users migrating to k8s 1.30 once Canonical releases 1.30 EKS optimized AMIs.

@AhmadMasry AhmadMasry closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Ubuntu 22.04 AMIs for EKS 1.29+
4 participants