Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Copy the v1 APIs for EC2NodeClass #6321

Merged
merged 5 commits into from
Jun 20, 2024
Merged

chore: Copy the v1 APIs for EC2NodeClass #6321

merged 5 commits into from
Jun 20, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jun 5, 2024 •
edited
Loading

Fixes #N/A

Description

  • This change adds the v1 APIs for the EC2NodeClass. This PR is intended to copy the v1beta1 APIs, defaults and validation. This PR does not change the EC2NodeClass used by controllers or includes conversion webhooks between the v1beta1 and v1 APIs
  • Conversion webhooks and updating all the controllers to use the v1 APIs will be followed-up in separate PRs.

How was this change tested?

  • All the tests have been copied over from v1beta1
  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Jun 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9385930043

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.4%) to 79.064%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9132951571: -3.4%
Covered Lines: 5725
Relevant Lines: 7241
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9386023035

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.077%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9132951571: -3.3%
Covered Lines: 5726
Relevant Lines: 7241
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9386052402

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.077%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9132951571: -3.3%
Covered Lines: 5726
Relevant Lines: 7241
💛 - Coveralls

@engedaam engedaam marked this pull request as ready for review June 5, 2024 16:33
@engedaam engedaam requested a review from a team as a code owner June 5, 2024 16:33
@engedaam engedaam requested a review from rschalo June 5, 2024 16:33
@engedaam engedaam changed the title chore: Add v1 APIs chore: Add v1 APIs for EC2NodeClass Jun 5, 2024
@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9423726001

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.127%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9421070174: -3.3%
Covered Lines: 5781
Relevant Lines: 7306
💛 - Coveralls

@engedaam engedaam force-pushed the create-v1-api branch 2 times, most recently from 4c72c7f to d3abc4d Compare June 14, 2024 20:05
@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9521735793

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.14%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9421070174: -3.3%
Covered Lines: 5782
Relevant Lines: 7306
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9521736512

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.14%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9421070174: -3.3%
Covered Lines: 5782
Relevant Lines: 7306
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9521790679

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.14%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9421070174: -3.3%
Covered Lines: 5782
Relevant Lines: 7306
💛 - Coveralls

@engedaam engedaam force-pushed the create-v1-api branch 2 times, most recently from 4e6dedb to 1b13071 Compare June 18, 2024 18:26
@engedaam engedaam changed the title chore: Add v1 APIs for EC2NodeClass chore: Copy the v1 APIs for EC2NodeClass Jun 18, 2024
@engedaam engedaam force-pushed the create-v1-api branch 2 times, most recently from 00eae63 to 05ce628 Compare June 20, 2024 19:39
@engedaam engedaam force-pushed the create-v1-api branch 2 times, most recently from 160cbdc to d7c0db0 Compare June 20, 2024 20:37
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9604047109

Details

  • 252 of 601 (41.93%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-3.3%) to 79.095%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9588967583: -3.3%
Covered Lines: 5785
Relevant Lines: 7314
💛 - Coveralls

jmdeal
jmdeal reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, otherwise looks good.

pkg/apis/v1/labels.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9605783816

Details

  • 253 of 602 (42.03%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.3%) to 79.139%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_defaults.go 0 1 0.0%
pkg/apis/v1/ec2nodeclass_status.go 0 9 0.0%
pkg/apis/v1/ec2nodeclass.go 7 20 35.0%
pkg/apis/v1/ec2nodeclass_validation.go 145 207 70.05%
pkg/apis/v1/zz_generated.deepcopy.go 67 331 20.24%
Totals Coverage Status
Change from base Build 9588967583: -3.3%
Covered Lines: 5789
Relevant Lines: 7315
💛 - Coveralls

jmdeal
jmdeal approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 5bf844f into aws:staging/v1 Jun 20, 2024
15 checks passed
@engedaam engedaam deleted the create-v1-api branch June 20, 2024 23:47
jonathan-innis pushed a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Jun 26, 2024
@engedaam @jonathan-innis
chore: Copy the v1 APIs for EC2NodeClass (aws#6321)
969396e
jonathan-innis pushed a commit to jonathan-innis/karpenter-provider-aws that referenced this pull request Jun 26, 2024
@engedaam @jonathan-innis
chore: Copy the v1 APIs for EC2NodeClass (aws#6321)
1fd7696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@rschalo rschalo Awaiting requested review from rschalo rschalo was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jmdeal