Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Exclude soak testing clusters from deletion #6334

Merged
merged 1 commit into from
Jun 7, 2024
Merged

ci: Exclude soak testing clusters from deletion #6334

merged 1 commit into from
Jun 7, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jun 7, 2024 •
edited
Loading

Fixes #N/A

Description

  • Exclude clusters from deleted for investigation
  • soak-periodic-55897225
  • soak-periodic-465714144

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Jun 7, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit d1711ef
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/666259650c61510008f8eb3e
😎 Deploy Preview https://deploy-preview-6334--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@engedaam engedaam changed the title ci: Exclude soak-periodic-465714144 cluster from deletion ci: Exclude soak-periodic-465714144 cluster from deletion Jun 7, 2024
@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9409534930

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.505%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9409328522: -0.02%
Covered Lines: 5546
Relevant Lines: 6722
💛 - Coveralls

@engedaam engedaam changed the title ci: Exclude soak-periodic-465714144 cluster from deletion ci: Exclude soak testing clusters from deletion Jun 7, 2024
@engedaam engedaam marked this pull request as ready for review June 7, 2024 00:25
@engedaam engedaam requested a review from a team as a code owner June 7, 2024 00:25
@engedaam engedaam requested a review from bwagner5 June 7, 2024 00:25
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9409637943

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.52%
Totals Coverage Status
Change from base Build 9409328522: 0.0%
Covered Lines: 5547
Relevant Lines: 6722
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9409651721

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 82.535%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9409328522: 0.02%
Covered Lines: 5548
Relevant Lines: 6722
💛 - Coveralls

@engedaam engedaam enabled auto-merge (squash) June 7, 2024 00:48
jmdeal
jmdeal approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9409877347

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.505%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.56%
Totals Coverage Status
Change from base Build 9409328522: -0.02%
Covered Lines: 5546
Relevant Lines: 6722
💛 - Coveralls

@engedaam engedaam merged commit 783073c into aws:main Jun 7, 2024
18 checks passed
@engedaam engedaam deleted the exclude-soak-cluster branch July 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @coveralls @jmdeal