Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync v1 staging branch with main #6335

Merged
merged 52 commits into from
Jun 7, 2024
Merged

chore: sync v1 staging branch with main #6335

merged 52 commits into from
Jun 7, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jun 7, 2024 •
edited
Loading

Fixes #N/A

Description
Syncs staging/v1 with main as of 78db4f0

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jonathan-innis and others added 30 commits May 16, 2024 18:54
@jonathan-innis
fix: Add truncating back to cloudprovider, considering minValues (aws…
8c91ba9 
…#6182)
@njtran
docs: fix migrating from cas node affinity guide (aws#6218)
6ecfb7f
@jmdeal
docs: update patch versions for v0.31.x-v0.36.x (aws#6230)
c980c0c
@jmdeal
docs: update instance type generation for AL2023 (aws#6231)
d219559
@tzneal
CodeGen updates from AWS API for pkg/providers/instancetype/zz_genera…
b69a2cc 
…ted.bandwidth.go
@dependabot
chore(deps): bump actions/checkout from 4.1.5 to 4.1.6 in /.github/ac…
a048364 
…tions/e2e/setup-cluster in the action-deps group (aws#6241)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump actions/checkout from 4.1.5 to 4.1.6 in /.github/ac…
c8b5797 
…tions/e2e/cleanup in the action-deps group (aws#6240)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump actions/checkout from 4.1.5 to 4.1.6 in /.github/ac…
7f31008 
…tions/e2e/slack/notify in the action-deps group (aws#6239)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump actions/checkout from 4.1.5 to 4.1.6 in /.github/ac…
4ae157c 
…tions/e2e/upgrade-crds in the action-deps group (aws#6237)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump actions/checkout from 4.1.5 to 4.1.6 in /.github/ac…
5944976 
…tions/e2e/install-prometheus in the action-deps group (aws#6236)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump actions/checkout from 4.1.5 to 4.1.6 in /.github/ac…
30d12d2 
…tions/e2e/install-karpenter in the action-deps group (aws#6235)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@engedaam
chore: Use AMI IDs in the logs for AMI discovery (aws#6220)
94bedac
@njtran
fix: adjust status conditions to only use root condition (aws#6195)
0cbf669
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go from 1.53.0 to 1.53.6 in …
5c2adb0 
…the go-deps group across 1 directory (aws#6246)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump the k8s-go-deps group with 4 updates (aws#6232)
9ea48d9 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@clhuang
add back TopologyManagerPolicy to bottlerocketsettings (aws#6248)
9c580fd
@jonathan-innis
Migrate logger from knative to controller-runtime (aws#6150)
d39fdb5
@jonathan-innis
BREAKING: Drop logger name injection and add consistent formatting fo…
9a71b6c 
…r K8s objects (aws#6255)
@Emberwalker
feat: Add extra fields to Bottlerocket k8s config (aws#6252)
a1167de
@njtran
chore: change knative ptr to lo ptr (aws#6260)
a7da616 
Co-authored-by: njtran <[email protected]>
@EigoOda @jonathan-innis
docs: Fix to add cury brackets (aws#6261)
e50a342 
Co-authored-by: Jonathan Innis <[email protected]>
@rschalo @jmdeal @jonathan-innis
chore: add label and ability to schedule for az-id (aws#6216)
8fa7793 
Co-authored-by: Jason Deal <[email protected]>
Co-authored-by: Jonathan Innis <[email protected]>
@engedaam
ci: Find all of instance-profiles in the CI account (aws#6137)
5c3dc15
@jmdeal
ci: enable eks 1.30 (aws#6265)
47608b1
@jmdeal
ci: drop cloudwatch agent (aws#6269)
b3076dc
@jmdeal
ci: pin upgrade source commit (aws#6270)
e517afa
@jmdeal
docs: add note about eksctl breaking change (aws#6276)
94283d2
@jmdeal
chore: bump karpenter to v0.37.0 (aws#6275)
918cc1c
@jmdeal
ci: revert AH config duplication fix (aws#6277)
490ef94
@github-actions @StableRelease @jmdeal
chore: Release v0.37.0 (aws#6278)
b95b3cf 
Co-authored-by: StableRelease <[email protected]>
Co-authored-by: Jason Deal <[email protected]>
jmdeal and others added 22 commits May 29, 2024 11:30
@jmdeal
docs: explicitly call out CRD upgrade requirement (aws#6288)
b8e235c
@jmdeal
test: fix recent AMI test for EKS 1.30 (aws#6289)
00e2a08
@afreyermuth98
docs: Adding Homa to the list of adopters (aws#6262)
7534595
@jmdeal
ci: add workflow_dispatch trigger to image canary (aws#6263)
fb78311
@jmdeal
ci: unpin soak cluster (aws#6290)
416a087
@github-actions @engedaam
chore: Update data from AWS APIs (aws#6274)
9a52b7c 
Co-authored-by: APICodeGen <[email protected]>
Co-authored-by: Amanuel Engeda <[email protected]>
@dependabot @engedaam
chore(deps): bump sigs.k8s.io/controller-runtime from 0.18.2 to 0.18.…
ae41cd7 
…3 in the k8s-go-deps group (aws#6272)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amanuel Engeda <[email protected]>
@jmdeal
docs: drop eksctl note and bump min version (aws#6297)
549b8ba
@dependabot @engedaam
chore(deps): bump the go-deps group across 1 directory with 2 updates (…
dd1f638 
…aws#6291)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amanuel Engeda <[email protected]>
@dependabot
chore(deps): bump docker/login-action from 3.1.0 to 3.2.0 in the acti…
17aa45b 
…ons-deps group (aws#6305)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump docker/login-action from 3.1.0 to 3.2.0 in /.github…
4d50b76 
…/actions/e2e/install-karpenter in the action-deps group (aws#6308)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go from 1.53.12 to 1.53.14 i…
5542dbf 
…n the go-deps group (aws#6307)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump docker/login-action from 3.1.0 to 3.2.0 in /.github…
5a29706 
…/actions/e2e/run-tests-private-cluster in the action-deps group (aws#6309)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions
chore: Update data from AWS APIs (aws#6312)
84f23ea 
Co-authored-by: APICodeGen <[email protected]>
@jmdeal
ci: upgrade eksctl to v0.180.0 (aws#6313)
7d74f0d
@engedaam
ci: Limit Sweeper Parallelism to avoid throttling (aws#6314)
fdae785
@jmdeal
deps: bump go to 1.22.4 (aws#6332)
00abb48
@njtran
docs: update website recommendations (aws#6317)
bb6f195
@engedaam
ci: Exclude soak testing clusters from deletion (aws#6334)
783073c
@gjreasoner @jonathan-innis
docs: adds more of ec2 spot heads up (aws#6219)
dba712f 
Co-authored-by: Jonathan Innis <[email protected]>
@cnmcavoy @jonathan-innis
docs: update karpenter docs around soft affinity behavior (aws#6172)
78db4f0 
Co-authored-by: Jonathan Innis <[email protected]>
@engedaam
Merge branch 'main' of https://github.com/aws/karpenter-provider-aws …
19c7ae0 
…into staging/v1
@engedaam engedaam changed the title chore: sync staging branch with main chore: sync v1 staging branch with main Jun 7, 2024
@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9419989776

Details

  • 170 of 211 (80.57%) changed or added relevant lines in 28 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 82.476%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/batcher/createfleet.go 0 1 0.0%
pkg/batcher/describeinstances.go 0 1 0.0%
pkg/controllers/interruption/controller.go 6 7 85.71%
pkg/providers/instancetype/instancetype.go 22 23 95.65%
pkg/providers/version/version.go 1 2 50.0%
pkg/providers/instance/instance.go 19 21 90.48%
pkg/providers/pricing/pricing.go 4 7 57.14%
pkg/fake/ec2api.go 4 8 50.0%
pkg/cloudprovider/cloudprovider.go 27 32 84.38%
pkg/controllers/nodeclass/status/readiness.go 5 11 45.45%
Files with Coverage Reduction New Missed Lines %
pkg/fake/ec2api.go 1 86.89%
Totals Coverage Status
Change from base Build 9132951571: 0.05%
Covered Lines: 5530
Relevant Lines: 6705
💛 - Coveralls

@engedaam engedaam marked this pull request as ready for review June 7, 2024 16:26
@engedaam engedaam requested a review from a team as a code owner June 7, 2024 16:26
@engedaam engedaam requested a review from jmdeal June 7, 2024 16:26
jonathan-innis
jonathan-innis approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 331f1ac into aws:staging/v1 Jun 7, 2024
13 checks passed
@engedaam engedaam deleted the bump-main branch July 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.