feat: Drop karpenter.sh/managed-by annotation #6379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9569656382Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9605074231Details
💛 - Coveralls |
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 9847447893Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
njtran
reviewed
Jul 8, 2024
Makefile
Outdated
| @@ -57,7 +57,8 @@ test: ## Run tests | |||
| -cover -coverprofile=coverage.out -outputdir=. -coverpkg=./... \ | |||
| --ginkgo.focus="${FOCUS}" \ | |||
| --ginkgo.randomize-all \ | |||
| --ginkgo.vv | |||
| --ginkgo.v \ | |||
| --ginkgo.fail-fast \ | |||
There was a problem hiding this comment.
I'm not sure we want this. We should also end the last line without a \
| managedRetrieved := lo.Filter(retrieved, func(nc *v1beta1.NodeClaim, _ int) bool { | ||
| return nc.Annotations[v1beta1.ManagedByAnnotationKey] != "" && nc.DeletionTimestamp.IsZero() | ||
| managedRetrieved := lo.Filter(retrieved, func(nc *corev1beta1.NodeClaim, _ int) bool { | ||
| return nc.Annotations[v1beta1.LabelNodeClass] != "" && nc.DeletionTimestamp.IsZero() |
There was a problem hiding this comment.
Can we use the nodepool label? I think it should be the same, but I want to make sure we follow the convention in the upstream provider.
Suggested change
| return nc.Annotations[v1beta1.LabelNodeClass] != "" && nc.DeletionTimestamp.IsZero() | |
| return nc.Annotations[v1beta1.LabelNodePool] != "" && nc.DeletionTimestamp.IsZero() |
| @@ -137,7 +137,8 @@ var _ = Describe("GarbageCollection", func() { | |||
| awsEnv.EC2API.Instances.Store(aws.StringValue(instance.InstanceId), instance) | |||
|
|
|||
| ExpectSingletonReconciled(ctx, garbageCollectionController) | |||
| _, err := cloudProvider.Get(ctx, providerID) | |||
| nc, err := cloudProvider.Get(ctx, providerID) | |||
| fmt.Println(nc) | |||
| @@ -288,9 +289,9 @@ var _ = Describe("GarbageCollection", func() { | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| }) | |||
| It("should not delete an instance if it was not launched by a NodeClaim", func() { | |||
| // Remove the "karpenter.sh/managed-by" tag (this isn't launched by a machine) | |||
| // Remove the nodepool tag (this isn't launched by a machine) | |||
There was a problem hiding this comment.
You say nodepool, but the label below is nodeclass. Mistake?
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Addresses concerns in #6319 and points to correct branch.
Description
How was this change tested?
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.