-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update docs to indicate requirements limit on NodePool is 100 #6441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jigisha620
force-pushed
the
docs-reqs-limit
branch
from
July 2, 2024 00:02
f9d171f
to
7d5fd1e
Compare
jigisha620
force-pushed
the
docs-reqs-limit
branch
from
July 2, 2024 00:14
7d5fd1e
to
7c0cb9d
Compare
Pull Request Test Coverage Report for Build 9751175192Details
💛 - Coveralls |
jigisha620
force-pushed
the
docs-reqs-limit
branch
from
July 2, 2024 01:25
7c0cb9d
to
a38731b
Compare
Pull Request Test Coverage Report for Build 9753472494Details
💛 - Coveralls |
jonathan-innis
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
LPetro
pushed a commit
to LPetro/karpenter-provider-aws
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
We have increased the limit on nodepool requirements to 100. This PR updates the doc to call out that change.
How was this change tested?
NA
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.