Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs to indicate requirements limit on NodePool is 100 #6441

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
We have increased the limit on nodepool requirements to 100. This PR updates the doc to call out that change.

How was this change tested?
NA

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 1, 2024 21:15
@jigisha620 jigisha620 requested a review from ellistarn July 1, 2024 21:15
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit a38731b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6683570acfdaaa000844d546
😎 Deploy Preview https://deploy-preview-6441--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9751175192

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.337%

Totals Coverage Status
Change from base Build 9739358800: 0.0%
Covered Lines: 5786
Relevant Lines: 7386

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9753472494

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.434%

Totals Coverage Status
Change from base Build 9752794287: 0.01%
Covered Lines: 5801
Relevant Lines: 7396

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit e8a3457 into aws:main Jul 2, 2024
18 checks passed
LPetro pushed a commit to LPetro/karpenter-provider-aws that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants