Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add pod-pids-limit to bottlerocket settings #6442

Merged
merged 1 commit into from
Jul 2, 2024
Merged

chore: Add pod-pids-limit to bottlerocket settings #6442

merged 1 commit into from
Jul 2, 2024

Conversation

jigisha620
Copy link
Contributor

@jigisha620 jigisha620 commented Jul 2, 2024 •
edited
Loading

Fixes #N/A

Description
Add pod-pids-limit to bottlerocket settings.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner July 2, 2024 05:45
@jigisha620 jigisha620 requested a review from tzneal July 2, 2024 05:45
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4236ea3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/668394045718cd0008abaec3

@coveralls
Copy link

coveralls commented Jul 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9755639770

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.421%
Totals Coverage Status
Change from base Build 9754740262: 0.0%
Covered Lines: 5800
Relevant Lines: 7396
💛 - Coveralls

jmdeal
jmdeal approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 65b79e1 into aws:main Jul 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jigisha620 @coveralls @jmdeal