Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate functional library in favor of lo and operatorpkg #6467

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jul 8, 2024

Fixes #N/A

Description
Buddy PR: kubernetes-sigs/karpenter#1398

How was this change tested?
make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner July 8, 2024 19:11
@ellistarn ellistarn requested a review from tzneal July 8, 2024 19:11
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6b0a364
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/668c39c92ef4150008b49516

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9845531667

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.842%

Totals Coverage Status
Change from base Build 9845441619: 0.0%
Covered Lines: 5951
Relevant Lines: 7548

💛 - Coveralls

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit e674d28 into aws:main Jul 8, 2024
18 checks passed
@ellistarn ellistarn deleted the fun branch July 8, 2024 19:35
rschalo pushed a commit to rschalo/karpenter-provider-aws that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants