Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding NodeClaims concept page to docs #6470

Merged
merged 12 commits into from
Aug 7, 2024

Conversation

chrisnegus
Copy link
Member

@chrisnegus chrisnegus commented Jul 9, 2024

Description: Created a new NodeClaims concept page. Also changed the order of other concept pages in left nav.

Does this change impact docs?

  • Yes, PR includes docs updates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chrisnegus chrisnegus requested a review from a team as a code owner July 9, 2024 03:49
@chrisnegus chrisnegus requested a review from rschalo July 9, 2024 03:49
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit e9fa32c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66b3cb436c5ea40008399b1d
😎 Deploy Preview https://deploy-preview-6470--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 10290567763

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.274%

Totals Coverage Status
Change from base Build 10288803223: 0.0%
Covered Lines: 5982
Relevant Lines: 7546

💛 - Coveralls

@chrisnegus chrisnegus requested a review from njtran July 9, 2024 04:39
@chrisnegus chrisnegus changed the title docs: Adding NodeClasses concept page to docs docs: Adding NodeClaims concept page to docs Jul 9, 2024
@chrisnegus
Copy link
Member Author

chrisnegus commented Jul 9, 2024

Here is a build of the NodeClaims doc to review: https://deploy-preview-6470--karpenter-docs-prod.netlify.app/preview/concepts/nodeclaims/

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how you've organized this! Some comments

website/content/en/preview/concepts/nodeclaim.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaim.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaim.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaim.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaim.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaim.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaim.md Outdated Show resolved Hide resolved
@chrisnegus
Copy link
Member Author

I love how you've organized this! Some comments

I'm glad you like it. I've responded to your comments. Please check if it's ready to merge.

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! a few comments and clarifications.

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkpointing

website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/static/nodeclaims.png Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/nodeclaims.md Outdated Show resolved Hide resolved
@njtran njtran merged commit 903b72b into aws:main Aug 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants