Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop validation webhooks and enable conversion webhooks #6488

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jul 10, 2024

Fixes #N/A

Description
This PR does the following:

  • Updates RBAC permissions for conversion webhooks
  • Passes conversion webhooks to the operator
  • Removes validation and defaulting webhooks for the EC2NodeClass
  • Adds a hack script to add the conversion stanza to CRDs
  • Removes the webhook.enabled setting from the helm chart.

How was this change tested?
In-Progress

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner July 10, 2024 19:47
@jmdeal jmdeal requested a review from rschalo July 10, 2024 19:47
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d82337f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/668f7a9dd9f9ac0008e6f328

@coveralls
Copy link

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 9886557329

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 68 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 78.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhooks/webhooks.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/apis/v1/zz_generated.deepcopy.go 68 0.0%
Totals Coverage Status
Change from base Build 9886167627: -0.2%
Covered Lines: 5612
Relevant Lines: 7124

💛 - Coveralls

Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d129d403454434b1329657aca337747e35dd0a70.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d129d403454434b1329657aca337747e35dd0a70" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-2bd36ac95318b6d22d3622e094ec95cf2c9f5a0d.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-2bd36ac95318b6d22d3622e094ec95cf2c9f5a0d" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d82337f29651ab677325210564ac895834fc1184.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d82337f29651ab677325210564ac895834fc1184" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmdeal jmdeal merged commit 9a54e8e into aws:main Jul 11, 2024
39 of 41 checks passed
@jmdeal jmdeal deleted the update-permissions branch August 14, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants