Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scheduling zone-id flake #6493

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jul 11, 2024

Fixes #N/A

Description
Fixes a flake in the zone-id scheduling tests, where we might get the node before the label with the expected zone-id has been propagated by the nodeclaim lifecycle controller.

How was this change tested?
make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner July 11, 2024 05:39
@jmdeal jmdeal requested a review from tzneal July 11, 2024 05:39
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3298176
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66900a3d86e01300099c1cb3

@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 9895238530

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.023%

Totals Coverage Status
Change from base Build 9886167627: 0.0%
Covered Lines: 5967
Relevant Lines: 7551

💛 - Coveralls

Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-9b180d1520415debaf3c93c964888d288a815601.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-9b180d1520415debaf3c93c964888d288a815601" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmdeal jmdeal enabled auto-merge (squash) July 11, 2024 16:37
@jmdeal jmdeal merged commit a6f27f3 into aws:main Jul 11, 2024
17 checks passed
@jmdeal jmdeal deleted the fix/scheduling-zone-id-flake branch August 14, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants