-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to v1 APIs #6502
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 9915073368Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
46bc2ac
to
072f132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work! Thanks for doing this. I think I found some artifacts of your testing
565675e
to
e321ff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #N/A
Description
This PR updates all in-code references to the
v1beta1
APIs tov1
. This is largely just find and replace, but there are a few changes to note:APIVersion
is updated toGroup
inNodeClassRef
KubeletConfig
is first parsed from the compat annotation, and then the new field on theEC2NodeClass
v1beta1
tov1
for CRDsWe've also updated the naming for package aliases due to the new
v1
conflicts. These packages have new names:How was this change tested?
make presubmit
and/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.