Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix upgrade suite #6505

Merged
merged 2 commits into from
Jul 12, 2024
Merged

test: fix upgrade suite #6505

merged 2 commits into from
Jul 12, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jul 12, 2024 •
edited
Loading

Fixes #N/A
Fix test for upgrade suite by upgrading CRDs before upgrading Karpenter.

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo
Copy link
Contributor Author

rschalo commented Jul 12, 2024

/karpenter snapshot

@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b360205
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66917df7b83fef0008983406

@rschalo rschalo marked this pull request as ready for review July 12, 2024 18:39
@rschalo rschalo requested a review from a team as a code owner July 12, 2024 18:39
@rschalo rschalo requested a review from tzneal July 12, 2024 18:39
@coveralls
Copy link

coveralls commented Jul 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9912841294

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.765%
Totals Coverage Status
Change from base Build 9909650823: 0.01%
Covered Lines: 5612
Relevant Lines: 7125
💛 - Coveralls

jmdeal
jmdeal approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rschalo rschalo enabled auto-merge (squash) July 12, 2024 19:04
@rschalo rschalo merged commit f001a3e into aws:main Jul 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @coveralls @jmdeal