Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix drift suite #6506

Merged
merged 2 commits into from
Jul 12, 2024
Merged

test: fix drift suite #6506

merged 2 commits into from
Jul 12, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jul 12, 2024

Fixes #N/A

Description
Drift where the nodepool would be altered during each update and then open up the nodepool to all possible EC2 instances. Some of these instances would be too small and use swap memory which causes kubelet to fail.

Example error:

Jul 12 20:24:01 kubelet[1596]: E0712 20:24:01.933476    1596 run.go:74] "command failed" err="failed to run Kubelet: running with swap on is not supported, please disable swap! or set --fail-swap-on flag to false. /proc/swaps contained: [Filename\t\t\t\tType\t\tSize\t\tUsed\t\tPriority /dev/zram0                              partition\t416>

How was this change tested?
make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner July 12, 2024 21:40
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit eb5bcd1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6691afd5c69b6f00083c5607

@coveralls
Copy link

coveralls commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9914944261

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 78.751%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 9912937561: -0.03%
Covered Lines: 5611
Relevant Lines: 7125

💛 - Coveralls

@rschalo rschalo enabled auto-merge (squash) July 12, 2024 21:47
@rschalo rschalo merged commit 5baf0d7 into aws:main Jul 12, 2024
17 checks passed
@rschalo rschalo deleted the fix-drift-test-flake branch July 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants