-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add testing to verify consistent generation for a no change update #6700
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 10359984624Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to
|
9fe3ac3
to
d117215
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! One question about ensuring that our testing covers the objects that we receive back from the apiserver too
5c875ab
to
1549477
Compare
1549477
to
6722591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to check if the kubelet values are what we expect?
7299231
to
fdd01a2
Compare
…into add-conversion-testing
fdd01a2
to
d49fdb7
Compare
Rebase failed
…karpenter into add-conversion-testing
Fixes #N/A
Description
How was this change tested?
/karpenter snapshot
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.