Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update v1 migration guide to enable the conversion webhooks by helm controller #6703

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Include the service account annotation for karpenter service account
  • Disable CRD conversion webhook block by the karpenter-crd helm chart

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner August 11, 2024 23:55
@engedaam engedaam requested a review from rschalo August 11, 2024 23:55
Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 3e304e1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ba5967438ee800080642fa
😎 Deploy Preview https://deploy-preview-6703--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we say that we also recommended upgrading to the latest patch version before going to v1?

website/content/en/preview/upgrading/v1-migration.md Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10357628478

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.294%

Totals Coverage Status
Change from base Build 10355029229: 0.0%
Covered Lines: 5997
Relevant Lines: 7563

💛 - Coveralls

@engedaam engedaam force-pushed the v1-upgrade-updates branch 3 times, most recently from b683f07 to 529a78c Compare August 12, 2024 17:52
njtran
njtran previously approved these changes Aug 12, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

website/content/en/preview/upgrading/v1-migration.md Outdated Show resolved Hide resolved
njtran
njtran previously approved these changes Aug 12, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engedaam engedaam enabled auto-merge (squash) August 12, 2024 18:53
@engedaam engedaam merged commit 6a07f65 into aws:main Aug 12, 2024
16 checks passed
@engedaam engedaam deleted the v1-upgrade-updates branch August 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants