Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to v1 Migration Guide #6709

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

chrisnegus
Copy link
Member

Description: A couple of small formatting fixes to v1 Migration Guide.

Does this change impact docs?

  • Yes, PR includes docs updates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chrisnegus chrisnegus requested a review from a team as a code owner August 12, 2024 15:31
@chrisnegus chrisnegus requested a review from tzneal August 12, 2024 15:31
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit e1dabcf
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66ba2b7a16dc7a0008274028
😎 Deploy Preview https://deploy-preview-6709--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) August 12, 2024 15:34
@coveralls
Copy link

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10354917751

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.281%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10347075222: -0.01%
Covered Lines: 5996
Relevant Lines: 7563

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 75222a1 into aws:main Aug 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants