Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu Backport and Version Bump v0.36.x #6712

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 12, 2024

Fixes #N/A

Description

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Aug 12, 2024

Pull Request Test Coverage Report for Build 10358806542

Details

  • 12 of 14 (85.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 77.649%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1/ec2nodeclass_conversion.go 9 11 81.82%
Totals Coverage Status
Change from base Build 10297106772: 0.004%
Covered Lines: 5607
Relevant Lines: 7221

💛 - Coveralls

@engedaam engedaam force-pushed the backport-bump-36 branch 2 times, most recently from 003db55 to 5962a43 Compare August 12, 2024 17:35
rschalo
rschalo previously approved these changes Aug 12, 2024
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rschalo rschalo self-requested a review August 12, 2024 18:08
@engedaam engedaam merged commit fc01bd5 into aws:release-v0.36.x Aug 12, 2024
13 checks passed
@engedaam engedaam deleted the backport-bump-36 branch August 12, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants