Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert to using ssm:GetParameter #6725

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Aug 13, 2024

Fixes #N/A

Description
Reverts to using ssm:GetParameter over ssm:GetParametersByPath to increase granularity on caching.

How was this change tested?
TODO

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8bd9735
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66bbe4a774206000089947a6

@jmdeal jmdeal force-pushed the chore/revert-ssm-permission branch from 78e4375 to 0eb28ae Compare August 13, 2024 17:35
@jmdeal jmdeal force-pushed the chore/revert-ssm-permission branch from d859102 to 522336d Compare August 13, 2024 18:53
@jmdeal jmdeal force-pushed the chore/revert-ssm-permission branch from 522336d to 6ab0964 Compare August 13, 2024 19:02
@coveralls
Copy link

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10378408052

Details

  • 101 of 103 (98.06%) changed or added relevant lines in 6 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 79.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/fake/ssmapi.go 25 27 92.59%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
pkg/fake/ssmapi.go 1 90.24%
pkg/providers/amifamily/types.go 5 80.95%
pkg/providers/version/version.go 8 65.85%
Totals Coverage Status
Change from base Build 10376315087: 0.03%
Covered Lines: 5919
Relevant Lines: 7462

💛 - Coveralls

@jmdeal jmdeal force-pushed the chore/revert-ssm-permission branch from e0f1c4c to a5a2ee0 Compare August 13, 2024 20:36
@jmdeal jmdeal force-pushed the chore/revert-ssm-permission branch from a5a2ee0 to f70d99e Compare August 13, 2024 20:42
@jmdeal jmdeal marked this pull request as ready for review August 13, 2024 21:35
@jmdeal jmdeal requested a review from a team as a code owner August 13, 2024 21:35
@jmdeal jmdeal requested a review from engedaam August 13, 2024 21:35
njtran
njtran previously approved these changes Aug 13, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-88f089b3b22423e6109cb5908deef82b02cdc18e.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-88f089b3b22423e6109cb5908deef82b02cdc18e" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@njtran njtran enabled auto-merge (squash) August 13, 2024 22:59
@njtran njtran merged commit c3bf2eb into aws:main Aug 13, 2024
16 checks passed
@jmdeal jmdeal deleted the chore/revert-ssm-permission branch August 14, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants