Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Limit parallelism on our GitHub action for version compatibility #6727

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 13, 2024

Fixes #N/A

Description

  • Limit the number of suites that run as part of our version compatibility testing. Prior to this change, the version compatibility workflow would create 3 suite (using 2 suites from our matrix job and upgrade suite). This PR will do two things: first reduce the number tests that are running at any given time from 18 suites to 12 suites, and reorder the test suites to reduce churn from similar operation correlating in one suite.
  • Reducing the test suites from 18 -> 12: Reducing the test runs to have at most 12 test suite running at a time. This will be to reduce the amount of transient errors due to throttling or issues caused by high request volume inside the testing account.
  • Re-order test suites: As both the upgrade and integration suite run the same set of tests(also happen to be the most aggressive), re-ordering the matrix will result the test suites to run in a staggered from each other to reduce the churn impact to the account. (should have no impact to the normal integration testing)

How was this change tested?

  • As these changes are to the workflow, we will need to merge in the PR to test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit e6e1594
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66bbcf0f9fd83d0008ceb4f1
😎 Deploy Preview https://deploy-preview-6727--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10377454000

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.281%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10376315087: -0.01%
Covered Lines: 5996
Relevant Lines: 7563

💛 - Coveralls

@engedaam engedaam marked this pull request as ready for review August 13, 2024 21:32
@engedaam engedaam requested a review from a team as a code owner August 13, 2024 21:32
@engedaam engedaam requested a review from njtran August 13, 2024 21:32
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 14ba0db into aws:main Aug 14, 2024
16 checks passed
@engedaam engedaam deleted the limit-test-run-for-conformance branch August 14, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants