Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache SSM calls (v0.35.x) #6730

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Aug 13, 2024

Fixes #N/A
Caches SSM parameter results for 24 hours to reduce duplicate API call volume. SSM parameter results are expected to be relatively static since we only query EKS managed SSM parameters.

Description
/karpenter snapshot

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner August 13, 2024 22:38
@coveralls
Copy link

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10378932089

Details

  • 31 of 33 (93.94%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 77.591%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 2 0.0%
Totals Coverage Status
Change from base Build 10359774813: 0.06%
Covered Lines: 5637
Relevant Lines: 7265

💛 - Coveralls

@jmdeal jmdeal force-pushed the backport/v0.35.x-ssm-cache branch 2 times, most recently from 72aab4f to 26cc7dd Compare August 13, 2024 23:46
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 7efde84 into aws:release-v0.35.x Aug 14, 2024
13 checks passed
@jmdeal jmdeal deleted the backport/v0.35.x-ssm-cache branch August 14, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants