Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update migration guide to add not for increased NodeClaimNotFou… #6734

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

jigisha620
Copy link
Contributor

…ndError

Fixes #N/A

Description
Karpenter will waits for the underlying instance to be completely terminated before deleting a node and orchestrates this by emitting NodeClaimNotFoundError. With this change we expect to see an increase in the NodeClaimNotFoundError. Documented this in the upgrade guide.

How was this change tested?
NA

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner August 14, 2024 00:56
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit da35a2d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66bce133ca254e0008d1a851
😎 Deploy Preview https://deploy-preview-6734--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10391730934

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 79.341%

Totals Coverage Status
Change from base Build 10391557579: 0.01%
Covered Lines: 5922
Relevant Lines: 7464

💛 - Coveralls

@jonathan-innis
Copy link
Contributor

@jigisha620 Can we update the PR description as well -- looks like the title for the PR got too long

@jigisha620 jigisha620 force-pushed the docs-update branch 3 times, most recently from 8b9c170 to 50197bf Compare August 14, 2024 16:44
njtran
njtran previously approved these changes Aug 14, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 67847d1 into aws:main Aug 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants