Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump sigs.k8s.io/karpenter to v1.0.0 #6753

Merged
merged 1 commit into from
Aug 14, 2024
Merged

deps: bump sigs.k8s.io/karpenter to v1.0.0 #6753

merged 1 commit into from
Aug 14, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Aug 14, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner August 14, 2024 19:12
@jmdeal jmdeal requested a review from ellistarn August 14, 2024 19:12
@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 44c60ab
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66bd01b8ad15cf00080ebbdc

njtran
njtran approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROOVEEEEEEEE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@jmdeal jmdeal enabled auto-merge (squash) August 14, 2024 19:13
jigisha620
jigisha620 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10393585453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.341%
Totals Coverage Status
Change from base Build 10393555974: 0.0%
Covered Lines: 5922
Relevant Lines: 7464
💛 - Coveralls

@jmdeal jmdeal merged commit 0b630eb into aws:main Aug 14, 2024
17 checks passed
@jmdeal jmdeal deleted the release/v1.0.0 branch August 14, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigisha620 jigisha620 jigisha620 approved these changes

@njtran njtran njtran approved these changes

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmdeal @coveralls @njtran @jigisha620