Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: drop alpha refs in troubleshooting guide #6757

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Aug 14, 2024

Fixes #N/A

Description
Remove references to Karpenters v1alphaX apis from the troubleshooting guide.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner August 14, 2024 22:28
@jmdeal jmdeal requested a review from jigisha620 August 14, 2024 22:28
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 359f49d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66bd348aaaf5c20008645bce
😎 Deploy Preview https://deploy-preview-6757--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10396114636

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 79.327%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 91.67%
Totals Coverage Status
Change from base Build 10396046060: -0.01%
Covered Lines: 5921
Relevant Lines: 7464

💛 - Coveralls

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 4965d7c into aws:main Aug 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants