chore: Added new policy to PodDisruptionBudget #7037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
njtran
reviewed
Sep 18, 2024
peterabarr
force-pushed
the
feat-pdb-policy
branch
from
f5bff64
to
8257a6d
Compare
|
@njtran Good point, I've added a function that ensures it only adds the field if the Kubernetes version is >= 1.27. |
peterabarr
force-pushed
the
feat-pdb-policy
branch
4 times, most recently
from
9458443
to
2db9c04
Compare
peterabarr
force-pushed
the
feat-pdb-policy
branch
from
2db9c04
to
7df72fe
Compare
njtran
reviewed
Sep 30, 2024
peterabarr
force-pushed
the
feat-pdb-policy
branch
5 times, most recently
from
e2d8e73
to
464f2c8
Compare
peterabarr
force-pushed
the
feat-pdb-policy
branch
2 times, most recently
from
fd0de9a
to
644339e
Compare
peterabarr
force-pushed
the
feat-pdb-policy
branch
from
644339e
to
1234ac8
Compare
charts/karpenter/values.yaml
Outdated
| @@ -49,6 +49,7 @@ podAnnotations: {} | |||
| podDisruptionBudget: | |||
| name: karpenter | |||
| maxUnavailable: 1 | |||
| unhealthyPodEvictionPolicy: | |||
There was a problem hiding this comment.
I suspect that we should set a default policy in our values.yaml if we are going to support this configuration parameter
charts/karpenter/README.md
Outdated
| @@ -70,6 +70,7 @@ cosign verify public.ecr.aws/karpenter/karpenter:1.0.0 \ | |||
| | podAnnotations | object | `{}` | Additional annotations for the pod. | | |||
| | podDisruptionBudget.maxUnavailable | int | `1` | | | |||
| | podDisruptionBudget.name | string | `"karpenter"` | | | |||
| | podDisruptionBudget.unhealthyPodEvictionPolicy | string | `nil` | Unhealthy pod eviction policy for the PDB. | | |||
There was a problem hiding this comment.
I question if we need this? What's the need for us to allow folks to configure this? Do you have a use-case for wanting to change this from the default eviction policy?
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
1.27 kube version minor
peterabarr
force-pushed
the
feat-pdb-policy
branch
from
c55e69f
to
892b5a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7025
Description
Added the
unhealthyPodEvictionPolicyto the Karpenter PDB.How was this change tested?
I generated a helm template file locally and tried to set
unhealthyPodEvictionPolicyin the chart values toAlwaysAllow:I also tried not setting anything in the chart values and expected that there would be no mention of
unhealthyPodEvictionPolicyin the spec:Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.