Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove AL2 AMISelectorTerms pin from e2e tests now that AL2023 accelerated AMIs are available #7253

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

bryantbiggs
Copy link
Member

Fixes #N/A

Description

  • Remove AL2 AMISelectorTerms pin from e2e tests now that AL2023 accelerated AMIs are available

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bryantbiggs bryantbiggs requested a review from a team as a code owner October 19, 2024 00:45
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit da60827
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67130114347e0b00082e61be

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11413026854

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.073%

Totals Coverage Status
Change from base Build 11412664511: 0.0%
Covered Lines: 5595
Relevant Lines: 6735

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-da608271a23023221b17f28a24e575943270f8e8.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-da608271a23023221b17f28a24e575943270f8e8" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@bryantbiggs
Copy link
Member Author

looks like network hiccup on the one test
image

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 73e387c into aws:main Oct 23, 2024
32 of 33 checks passed
@bryantbiggs bryantbiggs deleted the chore/al2023-tests branch October 23, 2024 17:09
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Oct 25, 2024
engedaam pushed a commit to engedaam/karpenter that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants