Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding logs to instance provider create #7270

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Adding logs to instance provider create #7270

merged 1 commit into from
Oct 24, 2024

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Adding error logs for instance provider create call.

How was this change tested?
manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner October 24, 2024 00:29
@netlify Netlify
Copy link

netlify bot commented Oct 24, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d7ddfe5
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/671994d7e2927900085e308a

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11490343472

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 82.873%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/instance/instance.go 1 2 50.0%
Totals Coverage Status
Change from base Build 11484974160: -0.01%
Covered Lines: 5642
Relevant Lines: 6808
💛 - Coveralls

jmdeal
jmdeal approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 89f9aeb into aws:main Oct 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdeal jmdeal jmdeal approved these changes

@danxwang22 danxwang22 Awaiting requested review from danxwang22 danxwang22 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jigisha620 @coveralls @jmdeal