Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp(v0.37.x): feat: invalidate SSM cache upon AMI deprecation (#7301) #7335

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Nov 6, 2024

Fixes #N/A

Description
Backport #7301 to v0.37.x. This backport did require some more substantial changes due to the changes in AMI discovery between v1 and v0.37.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner November 6, 2024 19:56
@jmdeal jmdeal requested a review from ellistarn November 6, 2024 19:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11710908157

Details

  • 123 of 154 (79.87%) changed or added relevant lines in 11 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 78.636%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/fake/ssmapi.go 26 27 96.3%
pkg/controllers/controllers.go 0 2 0.0%
pkg/providers/amifamily/ami.go 15 17 88.24%
pkg/apis/v1/ec2nodeclass.go 15 18 83.33%
pkg/operator/operator.go 0 5 0.0%
pkg/controllers/providers/ssm/invalidation/controller.go 34 42 80.95%
pkg/apis/v1/zz_generated.deepcopy.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.16%
pkg/fake/ssmapi.go 1 90.24%
Totals Coverage Status
Change from base Build 11470225379: -0.06%
Covered Lines: 5974
Relevant Lines: 7597

💛 - Coveralls

@jmdeal jmdeal changed the title feat: invalidate SSM cache upon AMI deprecation (#7301) cp(v0.37.x): feat: invalidate SSM cache upon AMI deprecation (#7301) Nov 6, 2024
Copy link
Contributor

@rschalo rschalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rschalo rschalo self-requested a review November 7, 2024 00:47
@jmdeal jmdeal merged commit 13888c4 into aws:release-v0.37.x Nov 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants