Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: instance profile tags optional #7337

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

jigisha620
Copy link
Contributor

Fixes #N/A

Description
Made instance profile tagging optional.

How was this change tested?
manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jigisha620 jigisha620 requested a review from a team as a code owner November 6, 2024 20:40
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 110e628
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/672bd423a532890008d688e7

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1ef7a82
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6732afb5f4ff800008a873a9

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11789031003

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 82.679%

Files with Coverage Reduction New Missed Lines %
pkg/fake/iamapi.go 10 56.1%
Totals Coverage Status
Change from base Build 11758502989: -0.1%
Covered Lines: 5661
Relevant Lines: 6847

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jigisha620 jigisha620 merged commit 8ae2b8c into aws:main Nov 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants