-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve CAS to Karpenter migration steps for clarity and automation #7343
Open
mozammil89
wants to merge
12
commits into
aws:main
Choose a base branch
from
mozammil89:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e578580
docs: updates on IAM and Karpenter chart installation
4675c58
Merge branch 'main' of https://github.com/mozammil89/karpenter-provid…
9ba931d
doc updates
91e239a
Merge branch 'aws:main' into main
mozammil89 1522be5
Merge branch 'main' of https://github.com/mozammil89/karpenter-provid…
fcbcf6c
replicating changes to other versions
a1d9f91
Merge branch 'main' into main
mozammil89 eb04171
Merge branch 'main' into main
mozammil89 842c6db
Update review comments _index.md
mozammil89 0a7b1ed
updates as part of review comments
d2c4587
update review comments
b5be7d1
Merge branch 'main' into main
mozammil89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
...tent/en/preview/getting-started/migrating-from-cas/scripts/step02-cloudformation-setup.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
curl -fsSL https://raw.githubusercontent.com/aws/karpenter-provider-aws/v"${KARPENTER_VERSION}"/website/content/en/preview/getting-started/getting-started-with-karpenter/cloudformation.yaml > "${TEMPOUT}" \ | ||
&& aws cloudformation deploy \ | ||
--stack-name "Karpenter-${CLUSTER_NAME}" \ | ||
--template-file "${TEMPOUT}" \ | ||
--capabilities CAPABILITY_NAMED_IAM \ | ||
--parameter-overrides "ClusterName=${CLUSTER_NAME}" |
15 changes: 0 additions & 15 deletions
15
website/content/en/preview/getting-started/migrating-from-cas/scripts/step02-node-iam.sh
This file was deleted.
Oops, something went wrong.
26 changes: 26 additions & 0 deletions
26
...te/content/en/preview/getting-started/migrating-from-cas/scripts/step03-controller-iam.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
cat << EOF > controller-trust-policy.json | ||
{ | ||
"Version": "2012-10-17", | ||
"Statement": [ | ||
{ | ||
"Effect": "Allow", | ||
"Principal": { | ||
"Federated": "arn:${AWS_PARTITION}:iam::${AWS_ACCOUNT_ID}:oidc-provider/${OIDC_ENDPOINT#*//}" | ||
}, | ||
"Action": "sts:AssumeRoleWithWebIdentity", | ||
"Condition": { | ||
"StringEquals": { | ||
"${OIDC_ENDPOINT#*//}:aud": "sts.amazonaws.com", | ||
"${OIDC_ENDPOINT#*//}:sub": "system:serviceaccount:${KARPENTER_NAMESPACE}:karpenter" | ||
} | ||
} | ||
} | ||
] | ||
} | ||
EOF | ||
|
||
aws iam create-role --role-name "KarpenterControllerRole-${CLUSTER_NAME}" \ | ||
--assume-role-policy-document file://controller-trust-policy.json | ||
|
||
aws iam attach-role-policy --role-name "KarpenterControllerRole-${CLUSTER_NAME}" \ | ||
--policy-arn "arn:aws:iam::${AWS_ACCOUNT_ID}:policy/KarpenterControllerPolicy-${CLUSTER_NAME}" |
11 changes: 0 additions & 11 deletions
11
...ite/content/en/preview/getting-started/migrating-from-cas/scripts/step03-node-policies.sh
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should stay, why would we remove it?