Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e ipv6 test issue #7359

Merged
merged 1 commit into from
Nov 9, 2024
Merged

fix e2e ipv6 test issue #7359

merged 1 commit into from
Nov 9, 2024

Conversation

haouc
Copy link
Contributor

@haouc haouc commented Nov 9, 2024

Fixes #N/A

Description
IPv6 e2e tests have incorrect instance ID passed. Also removed the ec2 API call to use existing helper function from env.
How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haouc haouc requested a review from a team as a code owner November 9, 2024 17:20
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 38075b1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/672f99f84818a30008baf332

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11758087896

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.798%

Totals Coverage Status
Change from base Build 11750931999: 0.0%
Covered Lines: 5675
Relevant Lines: 6854

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 7e8269b into aws:main Nov 9, 2024
18 checks passed
@haouc haouc deleted the ipv6 branch November 13, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants