Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Karpenter to include Node Status condition metrics #7371

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Nov 13, 2024

Fixes #N/A

Description

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 757471f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67341de907630100088b2ef1
😎 Deploy Preview https://deploy-preview-7371--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-757471fdac5c9066f0b35057f4c34062111391ba.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-757471fdac5c9066f0b35057f4c34062111391ba" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11810129358

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 82.679%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 11805307907: -0.03%
Covered Lines: 5661
Relevant Lines: 6847

💛 - Coveralls

@engedaam engedaam marked this pull request as ready for review November 13, 2024 16:13
@engedaam engedaam requested a review from a team as a code owner November 13, 2024 16:13
@jonathan-innis jonathan-innis changed the title chore: Bump Karpenter to inclue Node Status condation metrics chore: Bump Karpenter to inclue Node Status condition metrics Nov 13, 2024
@jonathan-innis jonathan-innis changed the title chore: Bump Karpenter to inclue Node Status condition metrics chore: Bump Karpenter to include Node Status condition metrics Nov 13, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit ddffb37 into aws:main Nov 13, 2024
30 of 33 checks passed
@engedaam engedaam deleted the bump-core branch November 13, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants